Awesome Privacy

Recent Commits

• Jesse Yurkovich (30 Nov 24)

  Fix: IO: wrong ObjectIdentifier used when trying to determine parent status The wrong ObjectIdentifier was used when trying to see if the object is a parent to something else in the export graph. This lead to accessing an invalid iterator which will assert with MSVC in Debug configurations. Accidentally regressed during the review of 428ab699dcf. Pull Request: https://projects.blender.org/blender/blender/pulls/131174

• Clément Foucault (29 Nov 24)

  Cleanup: Selection: Adress warning

• Clément Foucault (29 Nov 24)

  GPU: GLSL C++ Stub: Add packed type and small types

• Clément Foucault (29 Nov 24)

  Fix: Overlay-Next: Missing selection binding for object centers

• Clément Foucault (29 Nov 24)

  Fix: Overlay-Next: Broken selection on first click This was caused by querying on the selection state before it is setup. It is only setup just before the draw function. To fix this, we sync the `info_buf` just before drawing the overlays. Also add some safety to avoid uninitialized memory.

• Aras Pranckevicius (29 Nov 24)

  Fix #131097: Color space settings of >8bpp movie images do not work With exception of Sequencer, everywhere else in Blender it is assumed that float images are in linear color space. Movie files with more than 8 bit/channel precision are now loaded into float images (since 39c4c7cf3fe), but the "load and use them as an image" code path was not making sure that they are converted to linear color space. Pull Request: https://projects.blender.org/blender/blender/pulls/131141

• Sybren A. Stüvel (29 Nov 24)

  Refactor: BLI: Add MutableSpan::contains() function Add `bool MutableSpan<T>::contains(const T &value)` function, which is an exact copy of the function from the `Span<T>` class. This makes it possible to call `.contains()` directly on the `MutableSpan`, instead of having to call `.as_span()` first. Note that the `contains_ptr()` function was already copied from `Span` to `MutableSpan` before. No functional changes to the affected code, just the removal of the now no longer necessary `.to_span()` call. Pull Request: https://projects.blender.org/blender/blender/pulls/131149

• Miguel Pozo (29 Nov 24)

  Fix #130776: OpenGL: Use explicit uniform locations Ensure uniform locations are the same across specialization constants shader variations. Pull Request: https://projects.blender.org/blender/blender/pulls/131116

• Jeroen Bakker (29 Nov 24)

  Cleanup: Image Engine Before we start porting image engine to the new drawing manager we should do some cleanups. - Use similar namespace as other draw engines (`blender::image_engine`) - Switched InstanceData and Instance - Reduce parameters as drawing mode can access Instance. - Remove some templates to improve readability. Pull Request: https://projects.blender.org/blender/blender/pulls/131146

• Philipp Oeser (29 Nov 24)

  Fix: Grease Pencil: issues with the transform keyframes system Oversight in 09d2108bf502 For one, numinput for keyframes would be broken unless the mouse is moved first. Secondly, redo would also be broken (using the `Adjust Last Operation` panel or the `Repeat Last` operator). Above commit did a check for `TRANS_RUNNING` before calling `grease_pencil_layer_update_trans_data`. This isnt set in any of the above scenarios (it only gets set once the moues moves). This PR removes `TRANS_RUNNING` check to have proper calls to `grease_pencil_layer_update_trans_data`. It has one downside: you now get a `grease_pencil_layer_update_trans_data` as soon as you hit `G`. So it does remove_frame / add_frame unnecessarily (since we are still on the same frame), but only once, sees harmless in comparison to the two regression it fixes. Fixes #131092 Fixes #130793 Pull Request: https://projects.blender.org/blender/blender/pulls/131143

• Omar Emara (29 Nov 24)

  Fix: Compositor: Compile error with WITH_FFTW3 off

• Philipp Oeser (29 Nov 24)

  Fix: python exceptions on startup Seems like wrong syntax from 2c0d2a88caff Pull Request: https://projects.blender.org/blender/blender/pulls/131153

• Omar Emara (29 Nov 24)

  Compositor: Implement Glare node for new CPU compositor Reference #125968.

• YimingWu (29 Nov 24)

  Fix #128317: Missing `space_object` selector in Shrinkwrap constraint Selectors for properties `space_object` and `space_subtarget` are missing in Shrinkwrap constraint UI panel. This was because of the difference between property names it didn't use `space_template` to create those selectors. Since this is just a single special case, a branch was added in `draw_shrinkwrap` in similar fashion to display those selectors. Pull Request: https://projects.blender.org/blender/blender/pulls/128347

• Clément Foucault (29 Nov 24)

  Fix #131133: GPU: Navigation Gizmo sometimes doesn't display the axis lines Alignment was incorrect if vertex format stride was bigger than SSBO required alignment.

• Guillermo Venegas (29 Nov 24)

  Fix #130817: Make resource pool to cycle when swapchain images are presented Its not standard how `Present Engines` return images for presentation, and currently is expected that they cycle between swap-chain images with each `vkAcquireNextImageKHR` call. However present engines could return any available image, that can mean to reuse the last presented one if available. (This seem to be the behavior using `Layered on DXGI Swapchain` the default `Present Method` used with latest NVIDIA drivers on Windows). Since resource pools expects to images to cycle in a sequential order, if any present engine always return the same image for presentation only a single resource pool would be used for each rendered frame, and since resources are only released by cycling between resource pools, this resource pool would overflow since it never releases any resource. This changes makes resource pools to cycle each time a image is presented. Pull Request: https://projects.blender.org/blender/blender/pulls/131129

• Clément Foucault (29 Nov 24)

  Fix #131131: Overlay Next: Clip view crashes Blender Was simply a missing access to global uniform.

• Clément Foucault (29 Nov 24)

  GPU: C++ GLSL Stubs: Use unions instead of inheritance for swizzle This avoid stack overflow on GCC because types were getting too large (70 bytes for a float4) and created a lot of static memory for UBOs declarations.

• Jeroen Bakker (29 Nov 24)

  Fix: Overlay: Assert during bone selection in pose mode Detected when testing `ellie_animation.blend`. When trying to select bones the select_id_map is empty and would do an invalid resize of the output buffer. Pull Request: https://projects.blender.org/blender/blender/pulls/131140

• Clément Foucault (29 Nov 24)

  GPU: C++ GLSL Stubs: Add atomic sampler

• Jeroen Bakker (29 Nov 24)

  Fix #131135: Vulkan: Crash closing window When a main window contains a child window and the main window is closed it can crash as the context isn't available when destructing the VKFramebuffer of the child window. Pull Request: https://projects.blender.org/blender/blender/pulls/131137

• Jeroen Bakker (29 Nov 24)

  Fix: Vulkan: Compiling issue PR for colored debug groups didn't had the latest changes of main

• Jiarui-Yan (29 Nov 24)

  Vulkan: Colored debug groups This PR adds color to debug group so that RenderDoc can give color to different debug groups and sub-groups in the parent debug group. Ref: #124099 Pull Request: https://projects.blender.org/blender/blender/pulls/129340

• Jeroen Bakker (29 Nov 24)

  ShaderC: Version update v2022.3 -> v2024.3 Bump shaderc to latest release. The latest release contains fixes that we applied locally to improve compilation performance and also many fixes that improve platform compatibility. Pull Request: https://projects.blender.org/blender/blender/pulls/129971

• Jeroen Bakker (29 Nov 24)

  Vulkan: Update headers to v1.3.296 In Blender 4.4 we are planning to use `VK_KHR_dynamic_rendering_local_read` This is a fairly new extension and not included in the headers we are using at this moment. This PR will update the headers to the latest version. Pull Request: https://projects.blender.org/blender/blender/pulls/128995

• Alaska (29 Nov 24)

  Cycles: Add test for overlapping volumes with different anisotropy Ref: blender/blender-test-data!17 Ref: blender/blender#125595 Ref: blender/blender#123012 Pull Request: https://projects.blender.org/blender/blender/pulls/130491

• YimingWu (29 Nov 24)

  Fix #131049: Line Art: Prevent stroke generation in locked target layer Line art will not be able to insert any drawings into a locked target layer, this fix prevent such situation from crashing Blender. Pull Request: https://projects.blender.org/blender/blender/pulls/131073

• Campbell Barton (29 Nov 24)

  mypy: update checker to support specific files overlapping directories This allows single files to use different settings to other files in the same directory. Add check_unused_defines.py.

• Campbell Barton (29 Nov 24)

  Cleanup: use main functions to allow importing scripts Support importing scripts without running their logic to allow basic validation (see #130746). Parts of !131037 were used. Co-authored-by: Bastien Montagne <[email protected]>

• Campbell Barton (29 Nov 24)

  Extensions: use replace exists with lexists to check a path can be used Without this, a broken symbolic-link wasn't removed, causing renaming to fail.