Collabora Office

Recent Commits

• Caolán McNamara(24 Oct 26)

  document why the allowed external reference paths are advisory Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ib1ca24e42b429c0bf4b5f929d810b3cca1ce1bd5 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17089 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  sw html: check embed URLs against the allowed external reference paths similar to: commit 250104bf6f4c0ab0f5072a343453a170d5a8565f Date: Thu Oct 22 10:57:14 2026 +0000 xforms: check instance URLs against the allowed external reference paths (Change-Id I12207daf4646995b4063526f64bdf42ba9160649) The HTML import of embed and object now makes the same check that linked objects, sfx2 file links and Calc links already make. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I74021bed29b6a2d655c809f6af481ee3697d5c4b Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17087 Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(24 Oct 26)

  apply the same protocol check to calc sheet, area and external ref links These already check the allowed paths and hosts, so check the url protocol too, as the other link sources do. similar to: commit 52f436bd4e51d4c6509aab87dfcac5b13740b113 Date: Fri Oct 2 11:51:06 2026 +0000 apply the same source checks to a data pilot named by url Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I295a21f46763ee90663e8b77c1ff24453a818fed Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17111 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  note an image map area event from HTML import like the other HTML events similar to: commit f449b1d7b900a37f6f053e2a28452fdd25f6c72a Date: Sun Sep 27 23:24:50 2026 +0000 note a document event from HTML import like the other HTML events Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I964e4ef31170d110da5a8b3750efe96607d2cbaf Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17110 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  cypress: let the comment box show a selected thread before scrolling it The box scrolls a thread that was just selected into view in a later layout pass. When that pass ran after the test scrolled the box to reply 17, it scrolled the box back and left the menu of reply 18 out of view: long_comment_threads_spec.js Removing the last reply keeps the reply above it in place: Timed out retrying after 60050ms: `cy.click()` failed because this element: <div class="cool-annotation-menu" id="comment-annotation-menu-18" ... is being covered by another element: <canvas id="document-canvas" ... It failed the first attempt in 48 of 432 builds from 2026-10-20 to 2026-10-24. With every message delayed by 400ms it failed every run. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ib4426d9054dda1d7e753fa9e41664f322babd55d Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17109 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(24 Oct 26)

  escape the download name in Content-Disposition as a quoted-string A name with a double quote or a backslash in it was put between the quotes as-is, so the browser saved the download under the wrong name. since: commit 49193b3f5820bc7103b89aa24fabb1c2c69e6804 Date: Tue Dec 13 19:38:05 2016 +0530 tdf#104157: Fix Content-Type and add Content-Disposition for pdf Signed-off-by: Caolán McNamara <[email protected]> Change-Id: If7f90b9345ec9aec805a0e334a1486734d49ed2e Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17102 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Noel Grandin(24 Oct 26)

  remove JunitTest_sw_complex which has been dead since commit a6bb2e837264451ed896dd6783249e335e145605 Author: Michael Weghorn <[email protected]> Date: Fri Mar 15 10:52:04 2024 +0100 sw a11y: Disable unreliable CheckIndeterminateState test for now Change-Id: I02776ea38a87a9fa3f5a69a18929cfa442a7f9bd Signed-off-by: Noel Grandin <[email protected]> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17105 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Caolán McNamara <[email protected]>

• Noel Grandin(24 Oct 26)

  remove JunitTest_bean_complex and associated files. Has been dead since commit 4478b739ddade09425d496cbddee1542fdfd5e9b Author: Peter Foley <[email protected]> Date: Sun Sep 18 10:40:37 2011 -0400 convert bean to gbuild and add to tail_build Change-Id: I301cb4d835011e4145ce22f6829a743747dec33d Signed-off-by: Noel Grandin <[email protected]> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17104 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Caolán McNamara <[email protected]>

• Noel Grandin(24 Oct 26)

  convert toolkit_complex unit test from Java to C++ Note that this unit was recently accidentally disabled by me, I thought that I had restored it in commit 0b706f0dd911969c967e89ec84435889df96e627 Author: Noel Grandin <[email protected]> Date: Wed Sep 23 10:11:05 2026 +0200 fix --with-java build but mixed this one. I only converted the code that was actually being run. Some other java unit test code here was dead for some time. Change-Id: Ida9e8f6e870143dc1d104f8cfafc8458f39906d8 Signed-off-by: Noel Grandin <[email protected]> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17082 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  cypress: idle before the writer sidebar snapshot instead of sleeping Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I51ef723da1f5fc4ba8f625b3cc255a9817154338 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17101 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  cypress: wait for the double click to reach core instead of sleeping Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I48adf4e64f9287e08d129be740bb38226a88420a Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17100

• Caolán McNamara(24 Oct 26)

  cypress: wait for the click timer between two clicks in editable_area Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I223250c875c902e8c73f9d75f680763e7f45fd73 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17099

• Caolán McNamara(24 Oct 26)

  cypress: read comment positions after idle instead of sleeping the layout writes the positions in a layouting task, which processToIdle drains Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I7e4b4a0719acbe6208a830f36e3969777f91caa2 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17098

• Caolán McNamara(24 Oct 26)

  cypress: check for a jump back after idle instead of a second Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I336911b53704a3a1895ccfe57217de3bc8505908 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17097

• Caolán McNamara(24 Oct 26)

  cypress: wait for the navigator focus timer instead of a second With the cool#15912 fix reverted the test still fails, with focus on contenttree_0. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I8a4c8d86c1dc2afa8898eff553918601d10a3855 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17096

• Caolán McNamara(24 Oct 26)

  cypress: drop the waits between background changes cool#8096 is fixed, and the preview check retries until the preview updates. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ie95f6d761ab12b8d60287f193a79bd76e7477b2f Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17095

• Caolán McNamara(24 Oct 26)

  cypress: wait on idle for a wrong split correction instead of sleeping The resend that cool#13295 removed went out while the client handled core's split report, so a second idle round trip is enough to see it. With that fix reverted the test still fails, frozen column index: expected 3 to equal 4. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ieed743a0dcc0c4b4741f2756dc648a7c336094f2 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17094

• Caolán McNamara(24 Oct 26)

  cypress: check the slide count after idle instead of sleeping 5s Core reports the part count before it reports idle, so a slide deleted by mistake shows in the count straight away. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Id72f23b16682ca350fa6bfe75d8275ce4866d74b Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17093

• Caolán McNamara(24 Oct 26)

  cypress: sample the zoom animation by its frame scale, not a sleep The test slept 3s into an 8s zoom and 6s more for its end. It now samples once a third of the zoom is done and waits for the animation to end, so the zoom only needs 4s. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I76d85fb45b842d25ba30f7640747eef9e8c87da4 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17092

• Caolán McNamara(24 Oct 26)

  drop script commands in coolwsd for a read-only session similar to: commit 4d4df6ad894f2bd70ea740a604346a8a9d470282 Date: Mon Oct 19 09:02:42 2026 +0000 drop executescript in coolwsd when extensions are off Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I9091ab21c907bfd7c89ec5c8475e0624e18e86cc Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17103 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(23 Oct 26)

  update docParams access_token on Reset_Access_Token Only the ttl was updated, so a reconnect after a reset rebuilt the session's auth from the old token. since: commit 40839e8019079a9474b0965f254f309dac95916f Date: Thu May 5 18:17:38 2022 -0400 wsd: browser: Reset_Access_Token API to update access-tokens Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I224ec41ee1728efc446b2804f92d33db3b008b50 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17038 Reviewed-by: Ashod Nakashian <[email protected]> Tested-by: Jenkins CPCI <[email protected]>

• Aron Budea(22 Oct 26)

  xmldump: stylistic fixes Change-Id: Iba9c188b385b8e5952bc51f410cc3b24ccbedb1b Signed-off-by: Aron Budea <[email protected]> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/16766 Tested-by: Jenkins CPCI <[email protected]>

• Caolán McNamara(24 Oct 26)

  wsd: reattach a parked session only for the same user A reconnecting browser already gets a new view when the parked session has other permissions than its request. The user of the view should match the request in the same way. since: commit 1d3252ae6c72bb68aa3d188b3967a11351ed5712 Date: Wed Oct 21 05:13:19 2026 +0000 wsd: find, check and reattach a parked session in one call Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ic5e013f33d0a2d06d73730ef7c8633219846e6eb Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17084 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(23 Oct 26)

  sw html import: put image button pictures under link control as ODF import already does for form image controls similar to: commit 01a314d398a497e01d0b9e4b575f3b7c842b8622 Date: Fri Apr 17 08:09:18 2026 +0000 put links in form imagecontrols under link management Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I12993a2bb59aed6157e73f45b0ad09f5c80bc29c Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17085 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(22 Oct 26)

  don't start a document's own auto-reload timer in a kit The kit's client decides when a document reloads, so the document's reload setting is just kept in its properties. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I99f5480e5ba25f19b37f2ef23f5d9c8cdc248035 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/16885 Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(22 Oct 26)

  xforms: put instance URLs under link control An instance keeps the inline data from the document until the user allows link updates, and then reads the URL it names. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I2fdde2f925236d76fa24afb043e75817693ae332 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/16884

• Caolán McNamara(24 Oct 26)

  Related: cool#16194 compare uno command names without their ? arguments in the read-only view check and in the refused save reply since: commit 8e89e09ac04313bc5347d62e9f8b3447ed36206c Date: Thu Sep 10 09:45:39 2026 +0000 cool#16194 calc: keep the panes frozen in a read-only view Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I3f824e50ad91c04907669f0cbe8596696f623941 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17091 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Stephan Bergmann(24 Oct 26)

  UBSan CppunitTest_sw_writerfilter_dmapper apparently needs SvBaseLink RTTI now ...seeing it fail with > [LNK] CppunitTest/libtest_sw_writerfilter_dmapper.so > ld.lld: error: undefined symbol: typeinfo for sfx2::SvBaseLink > >>> referenced by DomainMapper_Impl.cxx > >>> engine/workdir/CxxObject/sw/qa/writerfilter/dmapper/DomainMapper_Impl.o:(.data+0x174a8) > >>> referenced by DomainMapper_Impl.cxx > >>> engine/workdir/CxxObject/sw/qa/writerfilter/dmapper/DomainMapper_Impl.o:(.data+0x17548) Signed-off-by: Stephan Bergmann <[email protected]> Change-Id: I97216a47750364530ded2adb504c7cbf511bb94c Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17090 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Noel Grandin <[email protected]>

• Caolán McNamara(24 Oct 26)

  cypress: run the lighthouse specs in the same make as the others The CI job now runs check-lighthouse and then check-desktop-mobile-multi. The a11y specs moved to the lighthouse target so that they would not delay the main suite, and running the two targets in series delays it again. Queue them first in the shared lanes instead, so the job only needs check-desktop-mobile-multi. Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ib22a574f4cadb36a79ad770dca626d7a4e64eacd Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17083 Tested-by: Jenkins CPCI <[email protected]>

• Henry Castro(23 Oct 26)

  engine: send the table being edited Inside a table a screen reader was handed the focused cell's paragraph and its row and column numbers, so the rest of the table did not exist for it. Send the rows of the innermost table holding the caret, up to 25 either side of the caret's row, each cell with its text and, when merged, its spans; a merged cell is listed once, at its top left position. Writer exposes a table split across pages as one accessible table per page, so the rows sent are those of the piece holding the caret. Change-Id: I9531194c0b354e152dc293f31a0c42327d8dffd3 Signed-off-by: Henry Castro <[email protected]> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/17014 Tested-by: Jenkins CPCI <[email protected]> Reviewed-by: Caolán McNamara <[email protected]>