Mumble

Recent Commits

• Robert Adam(07 Oct 26)

  Merge PR #7417: FIX(server): Drop connections that fail to authenticate in time

• Robert Adam(07 Oct 26)

  Merge PR #7420: FIX(server): Consolidate logging

• Robert Adam(07 Oct 26)

  FIX(server): Avoid redundant/duplicate newline in log msg

• Robert Adam(07 Oct 26)

  REFAC(client): Use cout/cerr while logger not yet initialized This is the client-side pendant to 64033e0311f3ebcb59f7b68c2a3c01515db505d6. Rely only on cout and cerr for output while the logging system is not yet initialized.

• Robert Adam(07 Oct 26)

  FIX(shared): Properly label log::fatal as [[noreturn]]

• Robert Adam(06 Oct 26)

  FIX(server): Consolidate logging We used direct writes to std::cerr in some places. That would lead to inconsistencies where e.g. parts of the server log was available in the event log but other parts weren't. By consistently using spdlog for logging we now ensure that all logs go to the same place(s). The exception of this is all output occurring before the loggers are properly set up. In those cases, we explicitly switch to using std::cout and std::cerr to get reliable and predictable behavior. This is exclusively output from the CLI parsing or for things requested via CLI parameter. This is assumed to just not be a thing on Windows as cout and cerr are invisible on Windows (*sigh*) for GUI applications.

• Robert Adam(06 Oct 26)

  Merge PR #7419: DOCS(protocol): add PluginDataTransmission to message type table

• Robert Adam(06 Oct 26)

  FIX(server): Drop connections that fail to authenticate in time New connections immediately got a ServerUser object, but nothing ever reaped one that lingered without authenticating: the existing idle timeout (checkTimeout/qtTimeout) only iterates qhUsers, which a connection joins only after a successful authentication, and a pre-auth connection does not even consume a session ID. A client could therefore open many connections and leave them idle in the Connected/Authenticating state to drive up the server's memory usage, bounded only by the OS file descriptor limit. Track not-yet-authenticated connections in a dedicated set and sweep it from a single server-wide timer, dropping any connection that has not reached the Authenticated state within the new handshaketimeout (default 10s, 0 disables). The set is owned by the main thread and never touched by the voice thread, so it needs no qrwlVoiceThread lock; the sweep collects before rejecting because rejectConnection() can synchronously re-enter connectionClosed() and mutate the set. AI-assisted

• Robert Adam(06 Oct 26)

  Merge PR #7395: MAINT: Add AGENTS.md

• maxer137(06 Oct 26)

  DOCS(protocol): add PluginDataTransmission to message type table Add `PluginDataTransmission` (type 26) to the list of supported protocol message types in the TCP stack documentation.

• Robert Adam(06 Oct 26)

  MAINT: Add more details to coding guidelines

• Robert Adam(30 Sept 26)

  MAINT: Add AGENTS.md

• Robert Adam(06 Oct 26)

  Merge PR #7418: CI(freebsd): Update to FreeBSD 15.1

• Robert Adam(06 Oct 26)

  CI(freebsd): Update to FreeBSD 15.1

• Hartmnt(05 Oct 26)

  Merge PR #7414: FIX(client): Fix inverted hostname check in ConnectDialog

• Hartmnt(05 Oct 26)

  FIX(client): Fix inverted hostname check in ConnectDialog Fixes #7412

• Robert Adam(04 Oct 26)

  Merge PR #7402: FIX(server): Multiple fixes

• Robert Adam(01 Oct 26)

  FIX(server): Only rename an online user if the rename via UserList succeeded When a client renamed a registered user via the UserList message, the result of storing the new name was ignored. If the new name already belonged to another account, the stored name stayed unchanged, but the online user was still renamed and broadcast to all clients under the other account's name. Only update and broadcast the name once it has been stored. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Apply a name change via Ice updateRegistration to the online user Renaming a registered user via Ice updateRegistration only changed the stored registration. If the user was online, the server kept the old name for it and clients were never told about the new one, unlike when renaming via the UserList message. Update the name of the online user and broadcast it, the same way a comment change was already handled. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Store the password passed to Ice registerUser Since the migration to the new DB backend (2907d6dd3), Ice registerUser converts the passed info map into a ServerUserInfo, which has no field for the password. The password (and KDF iteration count) passed by the caller was therefore silently dropped, creating an account without password, so that the user could not log in with the password the administrator had set. Set the password on the newly registered user, as before the migration. Fixes #6858 AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Prevent leaking groups with duplicate names in ACL updates Group's constructor registers the group in its channel's qhGroups under its name, overwriting any group already registered with that name. When an ACL update (client ACL message or Ice setACL) contained several groups with the same name, all but the last one were thus no longer referenced by anything and leaked. Delete a previously existing group before overwriting its pointer (which would leak it). AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Flush the ACL cache of the users whose temporary groups changed setTempGroups adds the given registration ID and session to temporary groups, but then looked up the registration ID in qhUsers, which is keyed by session. It thus flushed the cached permissions of whichever user happened to have a session equal to the registration ID, while the users actually affected (all sessions of that registered user) kept their stale cached permissions. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Remove a failed context action from the menu of the invoking user When the Ice callback for a context action failed, the server removed the callback registered for the invoking user, but sent the message removing the client-side menu entry to the user the action was invoked on (if any) instead. The invoking user thus kept a menu entry that no longer worked, and the target user got a removal for an entry it might not even have. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Broadcast the actual suppression state after ACL changes After an ACL change, clearACLCache updates the suppression state of users according to whether they may speak in their channel. The update sent to clients always claimed the user was suppressed, though, so users who regained the Speak permission were shown as suppressed by all clients while the server considered them unsuppressed. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Use the correct format specifier for unsigned values The server number in log messages and the uid/gid in the privilege dropping messages are unsigned, but were formatted with %d. Values above INT_MAX were thus printed as negative numbers (and the mismatch is undefined behavior). AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Erase empty per-address entries from the host user map qhHostUsers maps client addresses to the users connected from them, so that UDP packets from unknown peers can be matched to a user. Removing a user (once its UDP address is known, or when it disconnects) used operator[] and QSet::remove, which left an empty set behind for every address that ever had an authenticated client. With IPv6, a client has a practically unlimited number of addresses to connect from, so the map grew without bound. Remove the address entry once its set of users is empty, using a helper shared by both removal sites. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Keep temporary channel IDs apart from regular channel IDs Regular channels get the lowest ID that is free in the DB, which knows nothing about temporary channels. Temporary channels used that same value plus twice the channel count limit (or 1000000 without a limit), skipping IDs occupied by other temporary channels. Both ranges could still meet: the channel count limit can be lowered at runtime below the number of existing channels, and Ice addChannel doesn't enforce the limit at all. A regular channel then got the ID of a live temporary channel and replaced it in qhChannels. Once the temporary channel became empty, its deferred removal deleted the regular channel instead, including its DB entry. Allocate temporary channel IDs downwards from INT_MAX instead, skipping occupied IDs, so they can only meet the upwards growing regular IDs once there are more than 2 * 10^9 channels. Larger IDs would fit into the protocol's uint32, but the Ice interface represents channel IDs as int and uses -1 as the root channel's parent, and the plugin API uses int32_t. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Re-check conditions before removing an empty temporary channel When the last user leaves a temporary channel, its removal is deferred via a posted event that removed whatever channel had the same ID by the time the event got processed. Messages already received in the same batch (or from other clients) are handled before that event, so the channel could have been re-entered in the meantime (and got removed with its users being moved out), or it could have been removed and its ID reused by a newly created channel, which then got removed instead. Only remove the channel if it is still temporary and empty when the deferred removal is executed. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Prevent DB error when a user is both added to and removed from a group The group member table stores one entry per group and user, with a flag telling whether the user is added or removed. When an ACL update (client ACL message on a permanent channel, or Ice setACL) listed the same registered user in both the add and the remove list of a group, storing the channel violated the table's unique constraint. The resulting database error terminated the server. Only store the removal in that case. Removals already take precedence when checking group membership, so this doesn't change the effective membership. AI-assisted

• Robert Adam(01 Oct 26)

  FIX(server): Look up ACL user IDs before taking the voice lock When applying an ACL update (client ACL message or Ice setACL), every user ID referenced in the group member lists and ACL entries was validated via getRegisteredUserName() while holding the voice-thread write lock. For IDs not in the name cache, that function performs a synchronous call to the Ice authenticator and a DB query, once per occurrence. As the number of IDs is chosen by the sender, audio processing for the whole server could be stalled for a long time. Collect the referenced IDs, validate each distinct ID once before taking the lock, and only check against the result while holding it.