Awesome Privacy

Recent Commits

• thisconnect (29 Apr 24)

  Merge branch 'frontend-fiat-comma'

• thisconnect (23 Mar 24)

  frontend: properly paste localized amounts Amounts on invoices can use localized formatting for thousand and decimal separators. The BitBoxApp uses an input[type="number"] element as input field which converts strings to numbers. Pasting amounts with localized formatting can mess up the actual amount. i.e. 100,50 becomes 10050, which is 100x off. This change supports some additional formats by listening on the onPaste event and conditionally patching some formats. With this change, formats such as the following are now properly converted. - 100,50 - ,99 - 0,0000000000000000001 - 1'000'000,50 - 1'000'000.50 - 1 000 000.50 - 1.000.000,50 - 1.000,50 - 1,000.50 - 1,000,000.50 This change introduces a new NumberInput component that allows pasting more formats. It is still just an input field for numbers and not specifically aware or currencies. Not detected are numbers without decimals, i.e 1,000 will become 1 instead of 1000 (localized), accidentally pasting 1 is preferable than accidentally pasting 1000x too much.

• thisconnect (29 Apr 24)

  Merge branch 'frontend-webtest-ci-in-single-thread'

• thisconnect (22 Apr 24)

  frontend: run tests in ci in single thread CI sometimes still hangs, trying to run without threads - https://github.com/vitest-dev/vitest/issues/2008 - https://github.com/vitest-dev/vitest/issues/3077 In earlier vitest versions the optinon was --no-threads, but this changed to --pool=forks in: - https://github.com/vitest-dev/vitest/releases/tag/v1.0.0-beta.0 - https://github.com/vitest-dev/vitest/blob/main/docs/guide/migration.md#pools-are-standardized-4172 Changed vitest config, so that CI and make webtest are both using a single thread.

• Marko Bencun (28 Apr 24)

  Merge commit 'refs/pull/2659/head' of https://github.com/digitalbitbox/bitbox-wallet-app

• Marko Bencun (22 Mar 24)

  android: add mlkit-barcode-scanning dependency A user reported a crash when accessing the camera for QR code scanning. This is fixed by adding the ML Kit barcode scanning dependency to the build.gradle. See: https://developers.google.com/ml-kit/vision/barcode-scanning/android The meta-data declaration in the AndroidManifest might not be required to fix the issue.

• thisconnect (23 Apr 24)

  Merge branch 'frontend-amount-refactor'

• Marko Bencun (23 Apr 24)

  Merge remote-tracking branch 'benma/notarytool'

• Marko Bencun (23 Apr 24)

  Merge remote-tracking branch 'upstream/release-v4.42.0'

• sl (23 Apr 24)

  Merge branch 'frontend-loadingspinner'

• Marko Bencun (07 Feb 24)

  frontend: show spinner after unlock, before accounts are loaded After unlock, especially the first time, it can take many seconds for the initial set of accounts to be loaded. Until then, the app shows nothing in the sidebar and 'Please connect your device to get started'. The user is easily confused, it seems as something went wrong. We can probably speed up this loading with firmware and app changes, but this is a quick improvement that shows a spinner until the accounts become available.

• thisconnect (17 Apr 24)

  frontend: added changelog for localized formatting

• thisconnect (17 Apr 24)

  frontend: use native locale for amount formatting Before this change the amount formatting relied on the current i18n.language to format values, but i18n.language changes when the user selects a different language. It should always format amoutns in the native locale, regardless of the current langauge. Changed to format by native locale and added nativeLocale to app context as this does not change while the application is running.

• thisconnect (13 Apr 24)

  frontend: move arrow icons to icon component The account-summary arrows are static and do not have to be in JSX. Moved to svg file and import as regular image.

• thisconnect (08 Apr 24)

  frontend: localize amounts with detected separtor Detect what decimal and group punctuation is used to format amounts in the same format as the os. This is using native Intl.NumberFormat to detect the separtors. To simulate various locale in main.go, such as 'en-US', 'de_CH', 'fr'. use: ```diff diff --git a/cmd/servewallet/main.go b/cmd/servewallet/main.go index 4187a5ebd..b6ad132e2 100644 --- a/cmd/servewallet/main.go +++ b/cmd/servewallet/main.go @@ -99,6 +99,7 @@ func (webdevEnvironment) OnAuthSettingChanged(enabled bool) { // NativeLocale naively implements backend.Environment. // This version is unlikely to work on Windows. func (webdevEnvironment) NativeLocale() string { + return "es-419" ```

• thisconnect (05 Apr 24)

  frontend: easter egg to see detected lang Added information about detected native locale as hidden tooltop on the lang label, this can sometimes be helpful for debugging.

• thisconnect (04 Apr 24)

  frontend: localize amounts with simple string replace Format tousand and decimal separator with string replace. This was using Intl.NumberFormat before which works nice but is unsafe for very large or small numbers, due to JavaScript double floating point number precision. Indian numbering system is not supported as it uses different digit grouping.

• thisconnect (01 Mar 24)

  frontend: use native intl function to format amounts in the frontend Using native JavaScript Intl.NumberFormat implementation with i18n.language Added various tests, this implementation is not ideal as JavaScript cannot handle very large or small numbers.

• thisconnect (29 Feb 24)

  frontend: move render helper functions There are two pure functions that do not need to be declared in the component.

• thisconnect (29 Feb 24)

  frontend: restructure amount component - added newlines for better readability - removed unnecessary fragments

• beerosagos (22 Apr 24)

  Merge branch 'android-export'

• beerosagos (16 Apr 24)

  frontends/android: implement transactions export Transactions export feature was disabled for Android environment, this implements it. Android app storage space is sandboxed: the transactions csv is persisted inside the app dedicated storage and can be shared by any third-party app available on the system.

• Marko Bencun (22 Apr 24)

  Merge remote-tracking branch 'benma/locize' into release-v4.42.0

• Marko Bencun (22 Apr 24)

  frontend: make locize-pull

• thisconnect (19 Apr 24)

  Merge branch 'frontend-fix-webtest'

• thisconnect (18 Apr 24)

  frontend: fix i18n mocks This fixes the following error, that seems to be the cause the CI hangs forever. react-i18next:: You will need to pass in an i18next instance by using initReactI18next

• sl (18 Apr 24)

  Merge branch 'changelog-guide-title'

• sl (18 Apr 24)

  changelog: guide title changelog previously added in c37e7f76d8e62e00a89277b424559db76b887596 . Was wrongly added to 4.42.0 changelog, should be under Unreleased instead.

• thisconnect (18 Apr 24)

  Merge branch 'frontend-upgrade-node-v20'

• thisconnect (18 Apr 24)

  .github/workflows/ci: update CI image for Node.js v20.x