Electrum

Recent Commits

• Felix(03 Sept 26)

  Merge pull request #10903 from SomberNight/202608_fix_type_hints_optional type hints: (trivial) add missing "Optional" qualifiers

• SomberNight(28 Aug 26)

  transaction: fix return value of already_has_some_signatures() harmless in current usage.

• SomberNight(28 Aug 26)

  type hints: (trivial) small fixes all over

• SomberNight(27 Aug 26)

  type hints: (trivial) add missing "Optional" qualifiers In many cases with our type hinting, we do not explicitly specify that variables are allowed to be None when they have a default value of None. This PR now adds the missing explicit "Optional" markers. ----- Consider: ``` class Foo(NamedTuple): field: str = None ``` This type-hinting is technically incorrect, we should type hint it as either one of these options: - `field: Optional[str] = None` - `field: str | None = None` PyCharm has had soft-warnings about these lines for quite a while, however when doing type-inference, it used to internally "fix" the type by allowing None. Recently however it seems it is not doing the internal inference-fixing anymore, but assume that `path` has type `str` (as we specified) and then make "incorrect" inferences: ``` class Foo(NamedTuple): field: str = None def func(foo: Foo): assert foo.field is None print("function body") # <<< PyCharm now says this code is unreachable ``` I have whole function bodies grayed out and marked as dead code due to this. Example: https://github.com/spesmilo/electrum/blob/c82a0d12ef1e03a96d6180839f215c05efe9efe3/electrum/lnpeer.py#L2320, where htlc_set.parent_set_key is type-hinted as str, so the assert "must" always fail

• SomberNight(27 Aug 26)

  lnutil: rm unused "name" param from make_htlc_tx_with_open_channel()

• ThomasV(03 Sept 26)

  Merge pull request #10914 from SomberNight/202608_tests_lnhtlc lnhtlc: add sanity check we don't revoke our last valid commitment

• ThomasV(03 Sept 26)

  Merge pull request #10922 from accumulator/fix_use_change_config_sweeps wallet: make sure there is a change address in case of sweeps

• ThomasV(02 Sept 26)

  Merge pull request #10919 from f321x/qml_dont_delete_paid_invoices qml: prevent deleting paid invoices

• Sander van Grieken(02 Sept 26)

  wallet: make sure there is a change address in case of sweeps, or not all inputs are ismine. if config option `use_change` is `False`, wallet.make_unsigned_transaction can call the coinchooser without a change address. without one, coin chooser will take the first input of a tx to send change to, but this is not always an ismine address, e.g. for sweeps/swap-claims, and for batching sweeps with payments. make sure there is a change address for len(txo) == 0, or for not all inputs are ismine.

• f321x(02 Sept 26)

  qml: automatically remove paid invoices from invoice list Automatically remove an invoice from the invoice list if it was paid. Previously the user could manually delete it from the list in the same session, after a restart it was not added to the list anymore anyway.

• f321x(02 Sept 26)

  wallet: don't delete payment infos when deleting paid/inflight invoice/req Don't try to delete a `PaymentInfo` when deleting the attached `Invoice`/`Request` if they were already paid (or the payment is still inflight).

• ghost43(02 Sept 26)

  Merge pull request #10899 from spesmilo/harden_check_unfulfilled_htlc lnpeer: harden _check_unfulfilled_htlc

• ThomasV(02 Sept 26)

  Merge pull request #10906 from f321x/fix_lnchannel_preimage_extraction lnchannel: extract_preimage: fix len(witness) check

• ThomasV(02 Sept 26)

  Merge pull request #10910 from f321x/report_exception crash reporter: keep queue bounded, log enqueued exceptions

• f321x(28 Aug 26)

  lnwatcher: catch exc during ctx output sweeping Catch exceptions occuring during the sweep of a single ctx output and keep going sweeping the other outputs so we sweep at least those that do not crash and don't leave them on the table.

• ThomasV(28 Aug 26)

  lnpeer: move HTLC payment_hash check earlier in the flow. We must fail a HTLC to forward if its payment_hash matches one of our invoices. Instead of allowing the HTLC to enter a MPP set, we fail it before, in _check_unfulfilled_htlc. Also rewrite test_refuse_to_forward_htlc_that_corresponds_to_payreq_we_created: The new test uses send_trampoline_htlc_to_forward and only two peers, so it belongs in the TestPeerDirect class. The new test is logically equivalent and 4~5 times faster.

• ghost43(01 Sept 26)

  Merge pull request #10920 from SomberNight/202609_ln_chan_backup_db_upgrade lnutil: refactor channel backup classes to dataclass

• SomberNight(01 Sept 26)

  tests: db upgrade: add test for convert_version_72 It's a quite complicated conversion, that even pulls in BCDataStream as dependency. (though BCDataStream is kind of bitcoin-consensus-critical, so unlikely to change.) This test should hopefully catch and prevent future regressions.

• accumulator(01 Sept 26)

  Merge pull request #10917 from f321x/qml_fix_10916 qml: prevent concurrent biometric auth requests

• SomberNight(31 Aug 26)

  merge part of "lnpeer: harden _check_unfulfilled_htlc" extracted from https://github.com/spesmilo/electrum/pull/10899

• ghost43(31 Aug 26)

  Merge pull request #10909 from accumulator/lnpeer_fix_connection_wedges lnpeer: fix wedged peer connections

• f321x(28 Aug 26)

  crash_reporter: keep queue bounded, log if hook is not ready We universally use `send_exception_to_crash_reporter(e)` in the codebase, but if no exc hook was registered through a GUI the exceptions are just enqueued in an unbounded queue and never logged. If there is no additional log call they will go unnoticed when e.g. running in daemon mode without exc hook.

• f321x(31 Aug 26)

  qml: prevent concurrent biometric auth requests Don't allow initiating a new biometric auth request if there is still a pending one. I assume this can happen if the phone is slow to open the biometric auth prompt after the user requested auth, giving them enough time to e.g. click on the wallet again and request a second auth. Fixes https://github.com/spesmilo/electrum/issues/10916

• Sander van Grieken(29 Aug 26)

  lnpeer: fix wedged peer connections. On android, when the app is suspended in the background long enough that LN peer sockets die, electrum failed to recover these wedged connections. On desktop, the same issue occurs when suspending the system. - add timeout on ping messages. avoid wait forever on a dead socket - add connection monitor task on Peer taskgroup, similar to Interface.

• ThomasV(29 Aug 26)

  Merge pull request #10911 from SomberNight/202608_transaction_var_int transaction: de-dupe write_compact_size and var_int

• ThomasV(27 Aug 26)

  lnpeer: check the trampoline onion against the outer onion in all cases Apply the comparison of BOLT4 L547-L553 to forwarding requests too, not only if we are the final recipient: the difference between the two onions is the fee/cltv budget we are given (see _maybe_forward_trampoline). Also tolerate an inner payload with missing fields. Collapse the mpp and non-mpp cases while here: they are the same comparison, as a sender not using mpp must set total_msat equal to amt_to_forward (BOLT4 L406).

• ThomasV(29 Aug 26)

  Merge pull request #10904 from SomberNight/202608_tests_lnpeer_htlc_tracker tests: lnpeer: factor out "SenderHtlcResolvedTracker"

• SomberNight(29 Aug 26)

  lnhtlc: add sanity check we don't revoke our last valid commitment

• SomberNight(29 Aug 26)

  tests: lnhtlc: add a test showing local and remote ctns can drift apart

• ghost43(29 Aug 26)

  Merge pull request #10900 from Alwoch/unskip_chan_reserve_tests tests: Unskip, repair and make discoverable tests under TestChanReserve