Electrum

Recent Commits

• ghost43 (27 Jul 26)

  Merge pull request #10773 from f321x/ln_bug_mpp lnwallet: fix fee buget check regression

• f321x (27 Jul 26)

  test_lnpeer: add unittest for mpp fee budget check

• f321x (27 Jul 26)

  LNWallet: fix fee budget check regression The fee budget during local pathfinding route creation incorrectly compared the full payment amount against the full budget on every route instead of the partial amount against its fraction of the budget. This is a regression introduced by df5c8c4c9 and makes it possible for a payment to exceed the budget or a route to be incorrectly considered too expensive.

• Felix (27 Jul 26)

  Merge pull request #10772 from spesmilo/bump_review_ci ci: bump security review ci model to opus 5

• Felix (27 Jul 26)

  ci: bump security review ci model to opus 5 Bump the LLM used by the security review CI script from Claude Opus 4.8 to Claude Opus 5

• ThomasV (24 Jul 26)

  Merge pull request #10763 from f321x/register_onion_keys wallet_db: register onion_keys converter

• ghost43 (23 Jul 26)

  Merge pull request #10768 from SomberNight/202607_qt_rename_themes qt: rename color themes (the user-visible names of the themes)

• SomberNight (23 Jul 26)

  qt: rename color themes (the user-visible names of the themes) "Light" is actually the Platform-dependent system theme, where we let Qt define the palette and it leave it alone. Qt in turn mostly defers to the OS. On modern windows/macos/gnome/kde/etc, if the OS is set to "dark mode", Electrum will end up using a system-specific dark mode. Hence the name "Light" is confusing. "Dark" is the qdarkstyle theme, which is largely platform-independent. I think it's fine if these names are not completely "user-friendly". closes https://github.com/spesmilo/electrum/issues/10767

• ghost43 (23 Jul 26)

  Merge pull request #10765 from f321x/jsondb_recovery_modified json_db: set_modified after removing incomplete data

• ghost43 (23 Jul 26)

  Merge pull request #10764 from f321x/jsonpointer_escape_path json_db: escape '\' and '~' in json patch pointer

• f321x (21 Jul 26)

  json_db: set_modified after incomplete data Set the JsonDB modified after `maybe_load_incomplete_data` removed a corrupted patch. Otherwise we might not override the file on disk, append more patches and lose them all again on the next reload.

• f321x (21 Jul 26)

  json_db: escape '\' and '~' in json patch pointer > Because the characters '~' (%x7E) and '/' (%x2F) have special meanings in JSON Pointer, '~' needs to be encoded as '~0' and '/' needs to be encoded as '~1' when these characters appear in a reference token. https://www.rfc-editor.org/info/rfc6901/

• f321x (21 Jul 26)

  wallet_db: register onion_keys converter `Channel.onion_keys` had no registered converter for hex -> bytes, causing `pop_onion_key()` to return a hex str instead of bytes after the keys got loaded from db following a restart.

• ThomasV (16 Jul 26)

  Merge pull request #10753 from f321x/destroy_swap_transport swaps: destroy swap transport on failed initialization

• f321x (14 Jul 26)

  swaps: destroy swap transport on failed initialization Call `swap_transport.destroy()` when the swap transport initialization task fails, otherwise the task will keep the swap transport tasks alive, leaking a swap transport for each failed connection attempt.

• ghost43 (13 Jul 26)

  Merge pull request #10752 from SomberNight/202607_lntransport_exc lntransport: wrap connection errors in send_bytes_and_drain

• SomberNight (13 Jul 26)

  lntransport: wrap connection errors in send_bytes_and_drain LightningPeerConnectionClosed is handled in Peer.handle_disconnect. ``` 162.39 | E | lnpeer.Peer.[LNGossip, 02ab5336d0-d8be58cb] | Exception in main_loop: ConnectionResetError('Connection lost') Traceback (most recent call last): File "/home/user/wspace/electrum/electrum/util.py", line 1218, in wrapper return await func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/wspace/electrum/electrum/lnpeer.py", line 544, in wrapper_func return await func(self, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/wspace/electrum/electrum/lnpeer.py", line 558, in main_loop async with self.taskgroup as group: ^^^^^^^^^^^^^^ File "/home/user/wspace/aiorpcX/aiorpcx/curio.py", line 304, in __aexit__ await self.join() File "/home/user/wspace/electrum/electrum/util.py", line 1423, in join task.result() ~~~~~~~~~~~^^ File "/home/user/wspace/electrum/electrum/lnpeer.py", line 897, in _message_loop await self._process_message(msg) File "/home/user/wspace/electrum/electrum/lnpeer.py", line 277, in _process_message await f(*args) File "/home/user/wspace/electrum/electrum/lnpeer.py", line 389, in on_ping await self.transport.send_bytes_and_drain(raw_msg) File "/home/user/wspace/electrum/electrum/lntransport.py", line 238, in send_bytes_and_drain await self.writer.drain() File "/usr/lib/python3.13/asyncio/streams.py", line 386, in drain await self._protocol._drain_helper() File "/usr/lib/python3.13/asyncio/streams.py", line 166, in _drain_helper raise ConnectionResetError('Connection lost') ConnectionResetError: Connection lost ```

• SomberNight (10 Jul 26)

  contrib/make_download: fix imports not sure why this was not an issue before(?) perhaps due to python version differences ``` $ ./contrib/make_download /home/user/wspace/electrum-web Traceback (most recent call last): File "/home/user/wspace/electrum/./contrib/make_download", line 17, in <module> version_spec = importlib.util.spec_from_file_location('version', 'electrum/version.py') ^^^^^^^^^^^^^^ AttributeError: module 'importlib' has no attribute 'util' ```

• SomberNight (08 Jul 26)

  release notes: bump 4.8.0 date for second attempt We failed to get a full quorum to reproduce the prior git tag. The android apks were problematic to reproducibly build. should be fixed by https://github.com/spesmilo/electrum/pull/10739 here we go again

• ghost43 (07 Jul 26)

  Merge pull request #10743 from SomberNight/202607_fresh_clone_vartmp build: move default FRESH_CLONE location from /tmp to /var/tmp

• ghost43 (07 Jul 26)

  Merge pull request #10739 from SomberNight/202607_android_build android build: use --no-isolation, hash-pin more deps, only one install of setuptools

• f321x (07 Jul 26)

  android build: patch hostpython3 to not install setuptools Add a patch to the hostpython3 p4a recipe to prevent it from installing setuptools as part of the ensurepip invocation. Setuptools is later installed from a hash-pinned recipe. --- NOTE(ghost43): this is a workaround for reproducible-build issues we ran into during the 4.8.0 release. see https://github.com/spesmilo/electrum/pull/10739#issuecomment-4904680121 Since the last p4a rebase, p4a is installing some python packages using "pip install --target". We noticed that hostpython had two different versions of setuptools installed at the same time (two dist-info folders in site-packages/). This is due to the `--target` option for `pip install`. We are calling it with `--upgrade` too, but even then apparently it does not remove old versions. Indeed, when testing locally in a venv it leaves all .dist-infos there hanging. According to https://github.com/pypa/pip/issues/13763#issuecomment-3783977222, `--target` is not suitable or intended for this usecase at all. Current patch is only focused on setuptools, as a minimal workaround. Ultimately the same issue could arise with any other package. For example, still with ensurepip itself, we could be left with multiple versions of pip installed. Or anything we install via hostpython_prerequisites could have duplicate versions installed...

• SomberNight (07 Jul 26)

  build: move default FRESH_CLONE location from /tmp to /var/tmp Apparently many distros these days mount /tmp as RAM-disk. Even debian (starting with 13) does this now. The Android build needs to store dozens of gigs, so RAM is often not sufficiently large.

• SomberNight (04 Jul 26)

  android build: forbid buildozer to install unversioned deps of p4a While p4a itself does not need ninja in our usage, to build Qt6, we need ninja. However instead of installing it from PyPI, I think debian main is much more trustworthy.

• SomberNight (04 Jul 26)

  android build: build p4a recipes with --no-isolation the core change is https://github.com/spesmilo/python-for-android/commit/8c0fcc9ef2e559918ca96ecde6e09fe521bb1427 the rest here just follow that

• SomberNight (04 Jul 26)

  release notes: mention increased min android version ref https://github.com/spesmilo/electrum/pull/10485

• ghost43 (02 Jul 26)

  Merge pull request #10734 from f321x/qml_people qml: add myself to About page

• f321x (02 Jul 26)

  qml: add myself to About page

• ThomasV (02 Jul 26)

  update locale

• ThomasV (02 Jul 26)

  Merge pull request #10719 from f321x/release_v4.8.0 Release v4.8.0